Возникла ошибка java.io.IOException: поток закрыт при объединении 2 PDF-файлов

Question

Я пытался объединить два PDF-документа, которые пришли со страницы JSP с помощью загрузки файла. Я получаю файлы, помещаю их в список, но когда я пытаюсь прочитать их для слияния, я получаю сообщение «Поток закрыт». Я искал много ответов на это исключение, но ни один не помог. Так что, если поставить его снова, не уверен, где он терпит неудачу.

Ниже приведен код Java:

public class MergePdfUtility {
FormDataBean formData = null;

public String mergePdf(String contentType, InputStream inputStream, int formDataLength,
        HttpServletRequest request) {
    String saveFile = new String();
    String strUploadFile = "";
    File flUploadFile = null;
    formData = new FormDataBean();


    try {
        List<FileItem> items = new ServletFileUpload(new DiskFileItemFactory()).parseRequest(request);
        List<InputStream> list = new ArrayList<InputStream>();

        for (FileItem item : items) {
            if (item.isFormField()) {
                String fieldname = item.getFieldName();
                String fieldvalue = item.getString();
                if(fieldvalue == null || fieldvalue.length() == 0) {
                    fieldvalue = "Merger.pdf";
                }
                System.out.println("Field Value = " + fieldvalue);

                if (fieldname.equals("txtFileName")) {
                    formData.setStrFileName(fieldvalue);
                    System.out.println("successfully assigned");
                }
            } else {
                saveFile = FilenameUtils.getName(item.getName());                   
                if (saveFile.endsWith(".pdf")) {
                    inputStream = item.getInputStream();
                    contentType = item.getContentType();
                    strUploadFile = "D:\\Samik\\BCP\\" + saveFile;
                    flUploadFile = new File(strUploadFile);
                    FileOutputStream fileout = new FileOutputStream(flUploadFile);
                    BufferedOutputStream bout = new BufferedOutputStream(fileout);
                    BufferedInputStream bin = new BufferedInputStream(inputStream);
                    int byte_;

                    while ((byte_ = bin.read()) != -1) {
                        bout.write(byte_);
                    }
                    list.add(inputStream);

                    bout.close();
                    bin.close();
                    fileout.flush();
                    fileout.close();                        
                }
            }
        }

        mergePdf(list);
    } catch (Exception e) {         
        e.printStackTrace();            
        return "failure";
    }       
    return "success";
}

private static void mergePdf(List<InputStream> list)
        throws DocumentException, IOException {
    OutputStream mergeOutputStream = new FileOutputStream(new File("D:\\Samik\\BCP\\" + "Merger.pdf"));
    Document document = new Document();
    PdfWriter pdfWriter = PdfWriter.getInstance(document, mergeOutputStream);
    document.open();
    PdfContentByte pdfContentByte = pdfWriter.getDirectContent();
    for (InputStream tempInputStream : list) {
        PdfReader pdfReader = new PdfReader(tempInputStream);
        for (int i = 1; i <= pdfReader.getNumberOfPages(); i++) {
            document.newPage();
            PdfImportedPage page = pdfWriter.getImportedPage(pdfReader, i);
            pdfContentByte.addTemplate(page, 0, 0);
        }
    }
    mergeOutputStream.close();
    document.close();
}

}

Я получаю исключение в строке:

PdfReader pdfReader = new PdfReader(tempInputStream);

Исключение:

java.io.IOException: Stream Closed
at java.io.FileInputStream.readBytes(Native Method)
at java.io.FileInputStream.read(Unknown Source)
at com.itextpdf.text.pdf.RandomAccessFileOrArray.InputStreamToArray(RandomAccessFileOrArray.java:179)
at com.itextpdf.text.pdf.RandomAccessFileOrArray.<init>(RandomAccessFileOrArray.java:172)
at com.itextpdf.text.pdf.PdfReader.<init>(PdfReader.java:237)
at com.itextpdf.text.pdf.PdfReader.<init>(PdfReader.java:248)
at com.tcs.pdfutil.MergePdfUtility.mergePdf(MergePdfUtility.java:108)
at com.tcs.pdfutil.MergePdfUtility.mergePdf(MergePdfUtility.java:86)
at org.apache.jsp.MergePdfUtility_jsp._jspService(MergePdfUtility_jsp.java:83)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:432)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:390)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:334)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1041)
at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:603)
at   org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

Какая именно проблема? Где закрывается inputStream?

=============================================== =============================== Добавлено 3 июля:

Спасибо @ Анонимность. Это помогло мне решить проблему, но частично. Теперь я могу объединить до 5 документов в формате PDF и даже удалить исходные документы после их объединения, но я все еще не могу получить сообщение об успехе. После того, как все сделано идеально, элемент управления переходит к IOException, и я наконец-то получаю ту же ошибку - java.io.IOException: Stream Closed, что приводит к возвращению сообщения об ошибке. Не могу отследить, где я ошибаюсь.

Мой код теперь выглядит так:

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.util.ArrayList;
import java.util.List;

import javax.servlet.http.HttpServletRequest;

import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;
import org.apache.commons.io.FilenameUtils;

import com.itextpdf.text.Document;
import com.itextpdf.text.DocumentException;
import com.itextpdf.text.pdf.PdfContentByte;
import com.itextpdf.text.pdf.PdfImportedPage;
import com.itextpdf.text.pdf.PdfReader;
import com.itextpdf.text.pdf.PdfWriter;

public class MergePdfUtility {
FormDataBean formData = null;

public String mergePdf(String contentType, int formDataLength, HttpServletRequest request) {
    String saveFile = new String();
    String strUploadFile = "";
    File flUploadFile = null;
    formData = new FormDataBean();
    FileOutputStream fileout = null;
    BufferedOutputStream bout = null;
    BufferedInputStream bin = null;
    String strStatusMsg;
    InputStream inputStream1 = null;
    InputStream inputStream2 = null;
    InputStream inputStream3 = null;
    InputStream inputStream4 = null;
    InputStream inputStream5 = null;

    try {
        List<FileItem> items = new ServletFileUpload(new DiskFileItemFactory()).parseRequest(request);
        List<InputStream> list = new ArrayList<InputStream>();
        //List<InputStream> finalList = new ArrayList<InputStream>();

        for (FileItem item : items) {
            if (item.isFormField()) {
                String fieldname = item.getFieldName();
                String fieldvalue = item.getString() + ".pdf";
                if (fieldvalue == null || fieldvalue.length() == 0 || fieldvalue.equals(".pdf")) {
                    fieldvalue = "Merger.pdf";
                }
                System.out.println("Field Value = " + fieldvalue);

                if (fieldname.equals("txtFileName")) {
                    formData.setStrFileName(fieldvalue);
                    System.out.println("successfully assigned");
                }
            } else {
                saveFile = FilenameUtils.getName(item.getName());
                if (saveFile.endsWith(".pdf")) {
                    String strFieldName = item.getFieldName();
                    System.out.println(saveFile);

                    contentType = item.getContentType();
                    strUploadFile = "D:\\Samik\\BCP\\" + saveFile;
                    flUploadFile = new File(strUploadFile);
                    fileout = new FileOutputStream(flUploadFile);
                    bin = new BufferedInputStream(item.getInputStream());
                    bout = new BufferedOutputStream(fileout);

                    int byte_;

                    while ((byte_ = bin.read()) != -1) {
                        bout.write(byte_);
                    }
                    bout.flush();
                    bout.close();
                    //bin.close();
                    if(strFieldName.endsWith("1")) {
                        inputStream1 = new FileInputStream(flUploadFile);
                        list.add(inputStream1);
                        formData.setFile1(flUploadFile);
                    } else if(strFieldName.endsWith("2")) {
                        inputStream2 = new FileInputStream(flUploadFile);
                        list.add(inputStream2);
                        formData.setFile2(flUploadFile);
                    }
                    else if(strFieldName.endsWith("3")) {
                        inputStream3 = new FileInputStream(flUploadFile);
                        list.add(inputStream3);
                        formData.setFile3(flUploadFile);
                    }
                    else if(strFieldName.endsWith("4")) {
                        inputStream4 = new FileInputStream(flUploadFile);
                        list.add(inputStream4);
                        formData.setFile4(flUploadFile);
                    }
                    else if(strFieldName.endsWith("5")) {
                        inputStream5 = new FileInputStream(flUploadFile);
                        list.add(inputStream5);
                        formData.setFile5(flUploadFile);
                    }
                }
            }
        }

        mergePdf(list, formData);
        System.out.println("Finishing the main method");
        if(flUploadFile != null) {
            flUploadFile.delete();
        }
        strStatusMsg = "success";
    } catch (Exception e) {
        e.printStackTrace();
        strStatusMsg = "failure";
    }
    return strStatusMsg;
}

private static void mergePdf(List<InputStream> list, FormDataBean formData) {
    OutputStream mergeOutputStream = null;
    Document document = null;
    try {
        mergeOutputStream = new FileOutputStream(new File("D:\\Samik\\BCP\\" + formData.getStrFileName()));
        document = new Document();
        PdfWriter pdfWriter = PdfWriter.getInstance(document, mergeOutputStream);
        document.open();
        PdfContentByte pdfContentByte = pdfWriter.getDirectContent();
        for (InputStream tempInputStream : list) {
            PdfReader pdfReader = new PdfReader(tempInputStream);
            for (int i = 1; i <= pdfReader.getNumberOfPages(); i++) {
                document.newPage();
                PdfImportedPage page = pdfWriter.getImportedPage(pdfReader, i);
                pdfContentByte.addTemplate(page, 0, 0);                 
            }

            tempInputStream.close();
            pdfReader.close();
        }
        System.out.println("Merging completed");
        deleteFiles(formData);
        pdfWriter.flush();
        pdfWriter.close();
    } catch (DocumentException | IOException e) {
        try {
            throw e;
        } catch (Exception e1) {
            // TODO Auto-generated catch block
            e1.printStackTrace();
        }
    } finally {
        try {
            if (mergeOutputStream != null) {
                mergeOutputStream.close();
            }
            if (document != null) {
                document.close();
            }
            System.out.println("Exiting the method");
        } catch (IOException e1) {
            e1.printStackTrace();
        }
    }
}

private static void deleteFiles(FormDataBean formData) throws IOException, FileNotFoundException {
    if(formData.getFile1()!=null) {
        formData.getFile1().delete();
    }
    if(formData.getFile2()!=null) {
        formData.getFile2().delete();
    }
    if(formData.getFile3()!=null) {
        formData.getFile3().delete();
    }
    if(formData.getFile4()!=null) {
        formData.getFile4().delete();
    }
    if(formData.getFile5()!=null) {
        formData.getFile5().delete();
    }
}
}

Answer 1

Насколько я понимаю, InputStream был закрыт перед тем, как перейти в mergePdf(), когда BufferedInputStream закрывается, как показано ниже.

BufferedInputStream bin = new BufferedInputStream(inputStream);
...
list.add(inputStream);
...
bin.close();

Вы можете проверить код java.io.BufferedInputStream#close

public void close() throws IOException {
    byte[] buffer;
    while ( (buffer = buf) != null) {
        if (bufUpdater.compareAndSet(this, buffer, null)) {
            InputStream input = in;
            in = null;
            if (input != null)
                input.close();
            return;
        }
        // Else retry in case a new buf was CASed in fill()
    }
}

PS: Я предлагаю вам закрыть потоки ввода-вывода в блоке finally или использовать try-with-resources. Например:

private static void mergePdf(List<InputStream> list) {
    OutputStream mergeOutputStream = null;
    Document document = null;
    try{
        mergeOutputStream = new FileOutputStream(new File("D:\\Samik\\BCP\\" + "Merger.pdf"));
        document = new Document();
        PdfWriter pdfWriter = PdfWriter.getInstance(document, mergeOutputStream);
        document.open();
        PdfContentByte pdfContentByte = pdfWriter.getDirectContent();
        for (InputStream tempInputStream : list) {
            PdfReader pdfReader = new PdfReader(tempInputStream);
            for (int i = 1; i <= pdfReader.getNumberOfPages(); i++) {
                document.newPage();
                PdfImportedPage page = pdfWriter.getImportedPage(pdfReader, i);
                pdfContentByte.addTemplate(page, 0, 0);
            }
        }
    } catch (DocumentException|IOException e) {
        throw e;
    } finally {
        try {
            if(mergeOutputStream != null) {
                mergeOutputStream.close();
            }
            if(document != null) {
                document.close();
            }
        } catch (IOException e1) {
            e1.printStackTrace(); 
        }
    }
}

или (убедитесь, что в документе реализован java.io.Closeable):

private static void mergePdf(List<InputStream> list) throws DocumentException, IOException {
    try(OutputStream mergeOutputStream = new FileOutputStream(new File("D:\\Samik\\BCP\\" + "Merger.pdf")); Document document = new Document()){
        PdfWriter pdfWriter = PdfWriter.getInstance(document, mergeOutputStream);
        document.open();
        PdfContentByte pdfContentByte = pdfWriter.getDirectContent();
        for (InputStream tempInputStream : list) {
            PdfReader pdfReader = new PdfReader(tempInputStream);
            for (int i = 1; i <= pdfReader.getNumberOfPages(); i++) {
                document.newPage();
                PdfImportedPage page = pdfWriter.getImportedPage(pdfReader, i);
                pdfContentByte.addTemplate(page, 0, 0);
            }
        }
    }
}

---

обновлено 4 июля 2018. Метод испытания согласно https://developers.itextpdf.com/question/how-merge-documents-correctly.

public static void mergePdf(List<InputStream> inputStreams, String destinationFile) {
    try (OutputStream mergeOutputStream = new FileOutputStream(new File(destinationFile))) {
        Document document = new Document();
        PdfCopy copy = new PdfSmartCopy(document, mergeOutputStream);
        document.open();
        for (InputStream tempInputStream : inputStreams) {
            PdfReader pdfReader = new PdfReader(tempInputStream);
            copy.addDocument(pdfReader);
            System.out.println("Merging completed");
            pdfReader.close();
            tempInputStream.close();
        }
        document.close();
        copy.close();
    } catch (DocumentException | IOException e) {
        e.printStackTrace();
    }
}

---

обновлено 5 июля 2018 г. Я не знаю, какие рамки вы используете. Но я успешно слил два файла PDF с Springboot 2.0.1. Вот мои тестовые коды

@ResponseBody
@RequestMapping(value = "/mergePdf.json", method = POST)
public void mergePdf(@RequestParam("files") MultipartFile[] files) {
    mergePdfViaIText(Arrays.stream(files).map(file -> {
        try {
            LOG.debug(file.getOriginalFilename());
            return file.getInputStream();
        } catch (IOException e) {
            return null;
        }
    }).filter(Objects::nonNull).collect(Collectors.toList()), "D:/result.pdf");
}

public static void mergePdfViaIText(List<InputStream> inputStreams, String destinationPath) {
    try (OutputStream mergeOutputStream = new FileOutputStream(new File(destinationPath))) {
        Document document = new Document();
        PdfCopy copy = new PdfSmartCopy(document, mergeOutputStream);
        document.open();
        for (InputStream tempInputStream : inputStreams) {
            PdfReader pdfReader = new PdfReader(tempInputStream);
            copy.addDocument(pdfReader);
            LOG.info("Merging completed");
            pdfReader.close();
            tempInputStream.close();
        }
        document.close();
        copy.close();
    } catch (DocumentException | IOException e) {
        LOG.error(e.getMessage(), e);
    }
}