Строки VB.NET DataTable

Question

Я пытаюсь создать форму для входа.

Я создал базу данных на своем сервере и создал строки имя пользователя и пароль.Затем я создал пользователя root с паролем root.

, но у меня проблема с проверкой правильности имени пользователя и пароля, я не знаю, как задать ему 2 строки.

Dim conn = New SqlConnection("Data Source=SRV-SQL;Initial Catalog=prova;User ID=user;Password=user")
Dim sda = New SqlDataAdapter("select count(*) from tblLogin where username ='" + txtUsername.Text + "' and password='" + txtUserPwd.Text + "'", conn)
Dim dt = New DataTable()
sda.Fill(dt)
If (dt.Rows().ToString() = "1") Then
    MsgBox("Logged-in successfully")
Else
    MessageBox.Show("The username or the password is wrong!", "Warning!", MessageBoxButtons.OK, MessageBoxIcon.Error)
End If

Таблица:

Answer 1

Private Function CalculateHash(password As String, salt As String) As String
    'TODO:
    ' Suggest pulling the BCrypt from the NuGet gallery for this:
    ' https://www.nuget.org/packages/BCrypt-Official/
    ' Just remember that bcyrpt lib encodes salt as part of the password hash, so the function signatures and db table will be different.
End Function

Public Function CheckCredentials(UserName As String, Password As String) As Boolean
    Using conn As New SqlConnection("Data Source=SRV-SQL;Initial Catalog=prova;User ID=user;Password=user"), _
          ' Need to add a "Salt" column to your table, create a new random salt for each user when you create the user
          cmd As New SqlCommand("SELECT Salt, PwdHash FROM tblLogin WHERE username = @Username", conn)

        'Parameterized queries or NOTHING. String concatention is NOT OKAY here
        cmd.Parameters.Add("@UserName", SqlDbType.NVarChar, 50).Value = UserName

        conn.Open()   
        Using rdr As SqlDataReader = cmd.ExecuteReader()
            If Not rdr.Read() Then Return False

            Dim Salt As String = rdr("Salt")
            Dim PwdHash As String = rdr("PwdHash")

            'Compare HASHES, not Passwords
            Return PwdHash = CalculateHash(Password, Salt As String)
        End Using
    End Using
End Function

If CheckCredentials(txtUsername.Text, txtUserPwd.Text) Then
    MsgBox("Logged-in successfully")
Else
    MessageBox.Show("The username or the password is wrong!", "Warning!", MessageBoxButtons.OK, MessageBoxIcon.Error)
End If

Answer 2

Вместо этого используйте DataReader, используйте этот код и просто вызовите CheckLogin в кнопке входа или что-то еще.

Sub CheckLogin()

    Dim conn = New SqlConnection("Data Source=SRV-SQL;Initial Catalog=prova;User ID=user;Password=user")

    conn.Open()

    Try

        Dim query As String = "select count(*) from tblLogin where username = @username and password= @password "
        Dim cmd = New SqlCommand(query, conn)
        cmd.Parameters.AddWithValue("@username", txtUsername.Text)
        cmd.Parameters.AddWithValue("@password", txtUserPwd.Text)
        Dim DR As SqlDataReader = cmd.ExecuteReader()

        If DR.HasRows Then

            MsgBox("Logged-in successfully")

        Else

            MessageBox.Show("The username or the password is wrong!", "Warning!", MessageBoxButtons.OK, MessageBoxIcon.Error)

        End If

    Catch ex As Exception
        MsgBox(ex.Message)
    End Try

    conn.Close()

End Sub

Answer 3

Комментарии и пояснения в строке.

Private Sub VerifyLogin()
        'For the Return Value of the command
        Dim RetVal As Integer
        ' A Using...End Using will ensure that you connectionis closed and disposed event
        'it there is an error.
        Using conn = New SqlConnection("Data Source=SRV-SQL;Initial Catalog=prova;User ID=user;Password=user")
            'You don't need a DataAdapter, just a command
            'USE PARAMETERS. Yes, I am yelling :-) Even if you are the only user
            'it will save you headaches with syntax.
            Using cmd = New SqlCommand("select count(*) from tblLogin where username = @UserName and password= @Password;", conn)
                cmd.Parameters.Add("@UserName", SqlDbType.VarChar).Value = txtUsername.Text
                cmd.Parameters.Add("@Password", SqlDbType.VarChar).Value = txtUserPwd.Text
                'You are only returning one row
                'ExecuteScalar returns the value in the first column of the 
                'first row of the the data
                conn.Open()
                RetVal = CInt(cmd.ExecuteScalar)
            End Using
        End Using
        'No need to convert to a string just compare the Integer
        If RetVal = 1 Then
            MsgBox("Logged-in successfully")
        Else
            MessageBox.Show("The username or the password is wrong!", "Warning!", MessageBoxButtons.OK, MessageBoxIcon.Error)
        End If
End Sub