Оператор Splatting и Форматирования Работает в другом месте - PullRequest
Новая
       7

Оператор Splatting и Форматирования Работает в другом месте

0 голосов
/ 11 июня 2018

Меня попросили настроить скрипт, над которым я работал некоторое время назад.Я получил помощь для этого здесь .В скрипте я использую сплаттинг и оператор форматирования.Это работает дальше вверх по сценарию, но терпит неудачу внизу.У меня получился гораздо меньший образец, который показывает провал.Если вам нужно увидеть полный сценарий, я могу предоставить его.Некоторое время я смотрел на код, и мне не хватало чего-то простого. 

# Creating the Event Log and Source if it doesn't already exist.
# You should only have to create the log/source once and it needs to be done with an elevated prompt.
$EventLogFile = Get-EventLog -list | Where-Object {$_.LogDisplayName -eq "AD User Creation Script"} 
If (-Not $EventLogFile) {
    New-EventLog -LogName "AD User Creation Script" -Source "User Creation"
    New-EventLog -LogName "AD User Creation Script" -Source "Enable Existing User"
    New-EventLog -LogName "AD User Creation Script" -Source "Flush Groups"
    New-EventLog -LogName "AD User Creation Script" -Source "Change OU"
    New-EventLog -LogName "AD User Creation Script" -Source "Populate Groups"
}

# Nested hash table for school codes.
$SchoolCodes = @{
    "20" = @{
        Name = "Exeter Township Senior High"
        ADGroup1 = "Students"
        ADGroup2 = "Secondary Students"
    }
    "30" = @{
        Name = "Exeter Township Junior High"
        ADGroup1 = "Students"
        ADGroup2 = "Secondary Students"
    }
    "40" = @{
        Name = "Lorane Elementary School"
        ADGroup1 = "Students"
        ADGroup2 = "K4 Students"
    }
    "50" = @{
        Name = "Jacksonwald ES"
        ADGroup1 = "Students"
        ADGroup2 = "K4 Students"
    }
    "70" = @{
        Name = "Reiffton School"
        ADGroup1 = "Students"
        ADGroup2 = "Secondary Students"
    }
    "90" = @{
        Name = "Owatin Creek Elementary School"
        ADGroup1 = "Students"
        ADGroup2 = "K4 Students"
    }
} # End hash table


# CSV file being imported.
$CsvFile = "$env:USERPROFILE\Downloads\SampleData.csv"

# Import the contents of the CSV file.
$Users = Import-Csv -Path "$CsvFile"

# Loop through each line of the CSV, creating variables for each field.
ForEach ($User in $Users) {
    [String]$LoginName = $User.'Stu Access Login'
    If (-Not (Get-ADUser -Filter {SamAccountName -eq $LoginName})) {
        $FirstName = $User.'Student First Name'
        $LastName = $User.'Student Last Name'
        # The following is an example of SPLATTING.  A couple of the parameters (AccountPassword and Path) also use the FORMAT OPERATOR.
        $ADUserParams = @{
            Name = "$FirstName $LastName"
            SamAccountName = $LoginName
            GivenName = $FirstName
            Initials = $User.'I'
            Surname = $LastName
            DisplayName = "$FirstName $($User.'I') $LastName"
            UserPrincipalName = "$LoginName@academic.exeter.k12.pa.us"
            EmailAddress = "$LoginName@myexeter.org"
            Company = "$LoginName@myexeter.org"
            EmployeeID = $User.'Other ID'
            AccountPassword = ConvertTo-SecureString -String (
                '{0}{1}{2}#{3}' -f @(
                    $FirstName[0].ToString().ToUpper(),
                    $User.I[0].ToString().ToLower(),
                    $LastName[0].ToString().ToLower(),
                    $User.'Other ID')) -AsPlainText -Force
            Enabled = $True
            PasswordNeverExpires = $True
            CannotChangePassword = $True
            Path = 'OU={0},OU=Students,OU={1},OU=accounts,DC=academic,DC=exeter,DC=k12,DC=pa,DC=us' -f @(
                $User.'Grad Year',
                $SchoolCodes[$User.School].Name)
            WhatIf = $False
        } # End ADUserParams

        Try {
            # Create new user.
            New-ADUser @ADUserParams -Verbose -ErrorAction Stop
        }

        Catch {
            # If there's an error, write error to event the log.
            Write-EventLog -LogName "AD User Creation Script" -Source "User Creation" -EntryType Warning -EventId 1 -Message "Something went wrong with the creation of a new user, [$LoginName] : $_"
        }

        Try {
            # Add user to groups.
            Get-ADUser -Identity $LoginName | Add-ADPrincipalGroupMembership -MemberOf $SchoolCodes[$User.School].ADGroup1, $SchoolCodes[$User.School].ADGroup2 -Verbose -ErrorAction Stop
        }

        Catch {
            # If there's an error, write error to event the log.
            Write-EventLog -LogName "AD User Creation Script" -Source "Populate Groups" -EntryType Warning -EventId 2 -Message "Something went wrong with adding [$LoginName] to groups : $_"
        }

    } # End If

    # If the account already exists, it will likely be disabled.  The following will enable it and add it to the correct groups.
    Else {

        Try {
            # Enable the account if it already exists.
            Enable-ADAccount -Identity $LoginName -Confirm:$False -Verbose -ErrorAction Stop
        }

        Catch {
            # If there's an error, write error to event the log.
            Write-EventLog -LogName "AD User Creation Script" -Source "Enable Existing User" -EntryType Warning -EventId 3 -Message "Something went wrong with the enabling of the existing user, [$LoginName] : $_"
        }

        Try {
            # Move user to the correct OU.
            $MoveADObjectParams = @{
                Identity = $LoginName
                TargetPath = 'OU={0},OU=Students,OU={1},OU=accounts,DC=academic,DC=exeter,DC=k12,DC=pa,DC=us' -f @(
                    $User.'Grad Year',
                    $SchoolCodes[$User.School].Name)
            } # End MoveADObjectParams

            Move-ADObject @MoveADObjectParams -Verbose -ErrorAction Stop
        }

        Catch {
            # If there's an error, write error to event the log.
            Write-EventLog -LogName "AD User Creation Script" -Source "Change OU" -EntryType Warning -EventId 4 -Message "Something went wrong with moving the user, $LoginName, to another OU : $_"
        }

        Try {
            # Remove user from all groups except for Domain Users.
            $ExcessGroups = Get-ADPrincipalGroupMembership -Identity $LoginName | Where-Object {$_.Name -ne "Domain Users"}
            Remove-ADPrincipalGroupMembership -Identity $LoginName -MemberOf $ExcessGroups -Verbose -Confirm:$False
        }

        Catch {
            # If there's an error, write error to event the log.
            Write-EventLog -LogName "AD User Creation Script" -Source "Flush Groups" -EntryType Warning -EventId 5 -Message "Something went wrong with adding [$LoginName] to groups : $_"
        }

        Try {
            # Add user to groups.
            Get-ADUser -Identity $LoginName | Add-ADPrincipalGroupMembership -MemberOf $SchoolCodes[$User.School].ADGroup1, $SchoolCodes[$User.School].ADGroup2 -Verbose -ErrorAction Stop
        }

        Catch {
            # If there's an error, write error to event the log.
            Write-EventLog -LogName "AD User Creation Script" -Source "Populate Groups" -EntryType Warning -EventId 2 -Message "Something went wrong with adding [$LoginName] to groups : $_"
        }

    } # End Else 

} # End ForEach

Я вижу ошибку ниже.Похоже, что он не видит правильного пользователя, но объект находится в AD: 

Move-ADObject : Cannot find an object with identity: 'sicklsen000' under:
'DC=academic,DC=exeter,DC=k12,DC=pa,DC=us'.
At line:1 char:1
+ Move-ADObject @MoveADObjectParams -Verbose
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (sicklsen000:ADObject) [Move-ADObject], ADIdentityNotFoundException
    + FullyQualifiedErrorId : ActiveDirectoryCmdlet:Microsoft.ActiveDirectory.Management.ADIdentityNotFoundException,Microsoft.ActiveDirectory.Management.Commands.MoveADObject

Что странно, так это получение правильной информации, насколько я могу сказать: 

PS C:\Users\User:> $MoveADObjectParams

Name       Value
----       -----
TargetPath OU=2018,OU=Students,OU=Exeter Township Senior High,OU=accounts,DC=academic,DC=exeter,DC=k12,DC=pa,DC=us
Identity   sicklsen000

MyТестовый скрипт использует данные для 3 пользователей.Все они существуют.Вот пример: 

PS C:\WINDOWS\system32> Get-ADUser sicklsen000 | Select-Object SamAccountName, DistinguishedName

SamAccountName DistinguishedName                                                                                                        
-------------- -----------------                                                                                                        
sicklsen000    CN=Seneca Sickler,OU=2018,OU=Students,OU=Exeter Township Senior High,OU=accounts,DC=academic,DC=exeter,DC=k12,DC=pa,DC=us

1 Ответ

0 голосов
/ 12 июня 2018

Думаю, я все ближе, так как ошибка идет.Как я упоминал ранее, для параметра -Identity требуется свойство DistinguishedName , и я предоставлял ему свойство SamAccountName .

Ниже приведен код, который я изменил.Я больше не вижу ошибку, так что это хорошо. 

# Move user to the correct OU.
            $LoginNameDN = (Get-ADUser -Identity $LoginName).DistinguishedName
            $MoveADObjectParams = @{
                Identity = "$LoginNameDN"
                TargetPath = 'OU={0},OU=Students,OU={1},OU=accounts,DC=academic,DC=exeter,DC=k12,DC=pa,DC=us' -f @(
                    $User.'Grad Year',
                    $SchoolCodes[$User.School].Name)
            } # End MoveADObjectParams

            Move-ADObject @MoveADObjectParams -Verbose -ErrorAction Stop
        }
Добро пожаловать на сайт PullRequest, где вы можете задавать вопросы и получать ответы от других членов сообщества.

Похожие темы

...