ORA-00928: получение нескольких ошибок при передаче XML в хранимой процедуре

Question

Я вставляю данные в таблицу, используя XML, как показано ниже:

PROCEDURE insert_expt_excel(strxml  IN xmltype
                           ,poutmsg OUT NVARCHAR2)

 AS
  cnt NUMBER := 0;
BEGIN

  /* after update, delete query */
  FOR tmmapping IN (SELECT strxml.extract('excelData/R4GSTATE/text()').getstringval() AS r4gstate
                          ,strxml.extract('excelData/POLITICAL_STATE_NAME/text()').getstringval() AS political_state_name
                          ,strxml.extract('excelData/POLITICAL_STATE_CODE/text()').getstringval() AS political_state_code
                          ,strxml.extract('excelData/CMP/text()').getstringval() AS cmp
                          ,strxml.extract('excelData/SAP_ID/text()').getstringval() AS sap_id
                          ,strxml.extract('excelData/SITE_NAME/text()').getstringval() AS site_name
                          ,strxml.extract('excelData/RFCDATE/text()').getstringval() AS rfcdate
                          ,strxml.extract('excelData/RFS_DATE/text()').getstringval() AS rfs_date
                          ,strxml.extract('excelData/RFE1_DATE/text()').getstringval() AS rfe1_date
                          ,strxml.extract('excelData/SITE_DROP_DATE/text()').getstringval() AS site_drop_date
                          ,strxml.extract('excelData/INFRA_PROVIDER/text()').getstringval() AS infra_provider
                          ,strxml.extract('excelData/IP_COLO_SITEID/text()').getstringval() AS ip_colo_siteid
                          ,strxml.extract('excelData/VENDOR_CODE/text()').getstringval() AS vendor_code
                          ,strxml.extract('excelData/MW_INSTALLED/text()').getstringval() AS mw_installed
                          ,strxml.extract('excelData/DG_NONDG/text()').getstringval() AS dg_nondg
                          ,strxml.extract('excelData/EB_NONEB/text()').getstringval() AS eb_noneb
                          ,strxml.extract('excelData/TOWER_TYPE/text()').getstringval() AS tower_type
                          ,strxml.extract('excelData/ID_OD_COUNTCHANGE/text()').getstringval() AS id_od_countchange
                          ,strxml.extract('excelData/ID_OD_CHANGEDDATE/text()').getstringval() AS id_od_changeddate
                          ,strxml.extract('excelData/TENANCY_COUNTCHANGE/text()').getstringval() AS tenancy_countchange
                          ,strxml.extract('excelData/TENANCY_CHANGEDDATE/text()').getstringval() AS tenancy_changeddate
                      FROM TABLE(xmlsequence(strxml.extract('NewDataSet/excelData'))) strxml)
  LOOP
    INSERT INTO tbl_ipcolo_billing_mst
      (cmp, sap_id, id_od_countchange, id_od_changeddate, rrh_countchange,
       rrh_changeddate, tenancy_countchange, tenancy_changeddate, rfs_date,
       rfe1_date, infra_provider, ip_colo_siteid, site_name, r4gstate,
       mw_installed, dg_nondg, eb_noneb, tower_type, vendor_code, rfcdate,
       political_state_name, political_state_code, site_drop_date)
    VALUES
      (tmmapping.cmp, tmmapping.sap_id, tmmapping.id_od_countchange,
       tmmapping.id_od_changeddate, tmmapping.rrh_countchange,
       tmmapping.rrh_changeddate, tmmapping.tenancy_countchange,
       tmmapping.tenancy_changeddate, tmmapping.rfs_date, tmmapping.rfe1_date,
       tmmapping.infra_provider, tmmapping.ip_colo_siteid, tmmapping.site_name,
       tmmapping.r4gstate, tmmapping.mw_installed, tmmapping.dg_nondg,
       tmmapping.eb_noneb, tmmapping.tower_type, tmmapping.vendor_code,
       tmmapping.rfcdate, tmmapping.political_state_name,
       tmmapping.political_state_code, tmmapping.site_drop_date);
  END LOOP;

  cnt := SQL%ROWCOUNT;

  IF (cnt > 0)
  THEN
    BEGIN
      COMMIT;
      poutmsg := '1';
    END;
  ELSE
    BEGIN
      ROLLBACK;
      poutmsg := '0';

    END;
  END IF;

EXCEPTION
  WHEN OTHERS THEN
    ROLLBACK;

    poutmsg := '0';

END insert_expt_excel;

Но я получаю сообщение об ошибке:

ORA-06550: line 28, column 24:
PL/SQL: ORA-00904: "STRXML"."EXTRACT": invalid identifier
ORA-06550: line 7, column 1:
PL/SQL: SQL Statement ignored
ORA-06550: line 81, column 2:
PLS-00364: loop index variable 'TMMAPPING' use is invalid
ORA-06550: line 81, column 12:
PL/SQL: ORA-00984: column not allowed here
ORA-06550: line 31, column 1:
PL/SQL: SQL Statement ignored
ORA-06550: line 85, column 1:
PLS-00201: identifier 'CNT' must be declared
ORA-06550: line 85, column 1:
PL/SQL: Statement ignored
ORA-06550: line 87, column 4:
PLS-00201: identifier 'CNT' must be declared
ORA-06550: line 87, column 1:
PL/SQL: Statement ignored

Answer 1

Использование XMLTABLE:

Процедура :

CREATE PROCEDURE insert_expt_excel(
  strxml  IN xmltype,
  poutmsg OUT NVARCHAR2
)
AS
BEGIN
  INSERT INTO tbl_ipcolo_billing_mst (
    cmp,
    sap_id,
    id_od_countchange,
    id_od_changeddate,
    rrh_countchange,
    rrh_changeddate,
    tenancy_countchange,
    tenancy_changeddate,
    rfs_date,
    rfe1_date,
    infra_provider,
    ip_colo_siteid,
    site_name,
    r4gstate,
    mw_installed,
    dg_nondg,
    eb_noneb,
    tower_type,
    vendor_code,
    rfcdate,
    political_state_name,
    political_state_code,
    site_drop_date
  )
  SELECT cmp,
         sap_id,
         id_od_countchange,
         id_od_changeddate,
         NULL AS rrh_countchange,
         NULL AS rrh_changeddate,
         tenancy_countchange,
         tenancy_changeddate,
         rfs_date,
         rfe1_date,
         infra_provider,
         ip_colo_siteid,
         site_name,
         r4gstate,
         mw_installed,
         dg_nondg,
         eb_noneb,
         tower_type,
         vendor_code,
         rfcdate,
         political_state_name,
         political_state_code,
         site_drop_date
  FROM   XMLTABLE(
           '//NewDataSet/excelData'
           PASSING strxml
           COLUMNS cmp                  VARCHAR2(4000) PATH './CMP',
                   sap_id               VARCHAR2(4000) PATH './SAP_ID',
                   id_od_countchange    VARCHAR2(4000) PATH './ID_OD_COUNTCHANGE',
                   id_od_changeddate    DATE           PATH './ID_OD_CHANGEDDATE',
                   tenancy_countchange  VARCHAR2(4000) PATH './TENANCY_COUNTCHANGE',
                   tenancy_changeddate  DATE           PATH './TENANCY_CHANGEDDATE',
                   rfs_date             DATE           PATH './RFS_DATE',
                   rfe1_date            DATE           PATH './RFE1_DATE',
                   infra_provider       VARCHAR2(4000) PATH './INFRA_PROVIDER',
                   ip_colo_siteid       VARCHAR2(4000) PATH './IP_COLO_SITEID',
                   site_name            VARCHAR2(4000) PATH './SITE_NAME',
                   r4gstate             VARCHAR2(4000) PATH './R4GSTATE',
                   mw_installed         VARCHAR2(4000) PATH './MW_INSTALLED',
                   dg_nondg             VARCHAR2(4000) PATH './DG_NONDG',
                   eb_noneb             VARCHAR2(4000) PATH './EB_NONEB',
                   tower_type           VARCHAR2(4000) PATH './TOWER_TYPE',
                   vendor_code          VARCHAR2(4000) PATH './VENDOR_CODE',
                   rfcdate              DATE           PATH './RFCDATE',
                   political_state_name VARCHAR2(4000) PATH './POLITICAL_STATE_NAME',
                   political_state_code VARCHAR2(4000) PATH './POLITICAL_STATE_CODE',
                   site_drop_date       DATE           PATH './SITE_DROP_DATE'
         );

  IF ( SQL%ROWCOUNT > 0 ) THEN
    poutmsg := '1';
  ELSE
    poutmsg := '0';
  END IF;
EXCEPTION
  WHEN DUP_VAL_ON_INDEX THEN
    poutmsg := '0';
END insert_expt_excel;
/

Вам потребуется обновить его до соответствующих типов данных. rrh_countchange и rrh_changeddate не включены в ваш оператор SELECT.

Некоторые другие пункты:

• Не используйте OTHERS для перехвата всех исключений;вместо этого перехватите определенные ожидаемые исключения, и если возникнет непредвиденное исключение, вы сможете увидеть, что оно произошло, и отладить проблему, а не просто скрывать ее.
• Не используйте COMMIT вхранимая процедура ;вместо этого используйте его в вызывающем блоке, чтобы вы могли связать несколько хранимых процедур и COMMIT / ROLLBACK всех их как одну транзакцию.

Вызовите ее :

DECLARE
  success NUMBER(1,0);
BEGIN
  insert_expt_excel( XMLType( '<NewDataSet>
  <excelData>
    <CMP>abc</CMP>
    <SAP_ID>def</SAP_ID>
    <ID_OD_COUNTCHANGE>ghi</ID_OD_COUNTCHANGE>
    <ID_OD_CHANGEDDATE>2019-09-30</ID_OD_CHANGEDDATE>
  </excelData>
</NewDataSet>' ), success );
  IF success = 1 THEN
    COMMIT;
  ELSE
    ROLLBACK;
  END IF;
END;
/

Выход :

SELECT * FROM tbl_ipcolo_billing_mst;

CMP | SAP_ID | ID_OD_COUNTCHANGE | ID_OD_CHANGEDDATE | RRH_COUNTCHANGE | RRH_CHANGEDDATE | TENANCY_COUNTCHANGE | TENANCY_CHANGEDDATE | RFS_DATE | RFE1_DATE | INFRA_PROVIDER | IP_COLO_SITEID | SITE_NAME | R4GSTATE | MW_INSTALLED | DG_NONDG | EB_NONEB | TOWER_TYPE | VENDOR_CODE | RFCDATE | POLITICAL_STATE_NAME | POLITICAL_STATE_CODE | SITE_DROP_DATE
:-- | :----- | :---------------- | :---------------- | :-------------- | :-------------- | :------------------ | :------------------ | :------- | :-------- | :------------- | :------------- | :-------- | :------- | :----------- | :------- | :------- | :--------- | :---------- | :------ | :------------------- | :------------------- | :-------------
abc | def    | ghi               | 30-SEP-19         | <em>null</em>            | <em>null</em>            | <em>null</em>                | <em>null</em>                | <em>null</em>     | <em>null</em>      | <em>null</em>           | <em>null</em>           | <em>null</em>      | <em>null</em>     | <em>null</em>         | <em>null</em>     | <em>null</em>     | <em>null</em>       | <em>null</em>        | <em>null</em>    | <em>null</em>                 | <em>null</em>                 | <em>null</em>          

db <> скрипка здесь

Answer 2

Я могу воспроизвести ошибки, которые вы получаете, пытаясь запустить ваш код в точности так, как написано.

Отсутствует либо пакет, частью которого является процедура, либо "создание или замена" перед ним. После удаления оператора вставки (у меня нет таблицы) этот код компилируется.

create or replace PROCEDURE insert_expt_excel(strxml  IN xmltype
                           ,poutmsg OUT NVARCHAR2)

 AS
  cnt NUMBER := 0;
BEGIN

  /* after update, delete query */
  FOR tmmapping IN (SELECT strxml.extract('excelData/R4GSTATE/text()').getstringval() AS r4gstate
                          ,strxml.extract('excelData/POLITICAL_STATE_NAME/text()').getstringval() AS political_state_name
                          ,strxml.extract('excelData/POLITICAL_STATE_CODE/text()').getstringval() AS political_state_code
                          ,strxml.extract('excelData/CMP/text()').getstringval() AS cmp
                          ,strxml.extract('excelData/SAP_ID/text()').getstringval() AS sap_id
                          ,strxml.extract('excelData/SITE_NAME/text()').getstringval() AS site_name
                          ,strxml.extract('excelData/RFCDATE/text()').getstringval() AS rfcdate
                          ,strxml.extract('excelData/RFS_DATE/text()').getstringval() AS rfs_date
                          ,strxml.extract('excelData/RFE1_DATE/text()').getstringval() AS rfe1_date
                          ,strxml.extract('excelData/SITE_DROP_DATE/text()').getstringval() AS site_drop_date
                          ,strxml.extract('excelData/INFRA_PROVIDER/text()').getstringval() AS infra_provider
                          ,strxml.extract('excelData/IP_COLO_SITEID/text()').getstringval() AS ip_colo_siteid
                          ,strxml.extract('excelData/VENDOR_CODE/text()').getstringval() AS vendor_code
                          ,strxml.extract('excelData/MW_INSTALLED/text()').getstringval() AS mw_installed
                          ,strxml.extract('excelData/DG_NONDG/text()').getstringval() AS dg_nondg
                          ,strxml.extract('excelData/EB_NONEB/text()').getstringval() AS eb_noneb
                          ,strxml.extract('excelData/TOWER_TYPE/text()').getstringval() AS tower_type
                          ,strxml.extract('excelData/ID_OD_COUNTCHANGE/text()').getstringval() AS id_od_countchange
                          ,strxml.extract('excelData/ID_OD_CHANGEDDATE/text()').getstringval() AS id_od_changeddate
                          ,strxml.extract('excelData/TENANCY_COUNTCHANGE/text()').getstringval() AS tenancy_countchange
                          ,strxml.extract('excelData/TENANCY_CHANGEDDATE/text()').getstringval() AS tenancy_changeddate
                      FROM TABLE(xmlsequence(strxml.extract('NewDataSet/excelData'))) strxml)
  LOOP
    null;
  END LOOP;

  cnt := SQL%ROWCOUNT;

  IF (cnt > 0)
  THEN
    BEGIN
      COMMIT;
      poutmsg := '1';
    END;
  ELSE
    BEGIN
      ROLLBACK;
      poutmsg := '0';

    END;
  END IF;

EXCEPTION
  WHEN OTHERS THEN
    ROLLBACK;

    poutmsg := '0';

END insert_expt_excel;

Answer 3

Альтернативный способ без использования FOR LOOP, который может привести к неоптимальной производительности, так как строка за строкой подход будет использовать XMLTable - см. Пример ниже:

insert into tab (a,b)
with dt as (
select xmltype(
'<tab>
 <rec>
   <a>a1</a>
   <b>b1</b>
 </rec>  
 <rec>
   <a>a2</a>
   <b>b2</b>
 </rec> 
</tab>') col
from dual
)
select x.a,x.b 
from dt,
     XMLTable(
     'for $i in /tab/rec      
      return $i' 
      passing  (dt.col)
      columns
      a varchar2(5) path '//a',
      b varchar2(5) path '//b'
 ) x  
; 


select * from tab;

A     B    
----- -----
a1    b1   
a2    b2