Во-первых, исправьте движение двух машин, чтобы они не выходили за границы холста.
import java.io.FileNotFoundException;
import javafx.animation.KeyFrame;
import javafx.animation.Timeline;
import javafx.application.Application;
import javafx.event.ActionEvent;
import javafx.event.EventHandler;
import javafx.geometry.Bounds;
import javafx.scene.Scene;
import javafx.scene.image.Image;
import javafx.scene.image.ImageView;
import javafx.scene.layout.Pane;
import javafx.scene.paint.Color;
import javafx.stage.Stage;
import javafx.util.Duration;
public class Car extends Application {
private Pane canvas;
private static final String[] CIRCLES_128 = {
"https://cdn3.iconfinder.com/data/icons/softwaredemo/PNG/128x128/Circle_Green.png",
"https://cdn3.iconfinder.com/data/icons/softwaredemo/PNG/128x128/Circle_Red.png",
};
@Override
public void start(final Stage primaryStage) throws FileNotFoundException {
canvas = new Pane();
final Scene scene = new Scene(canvas, 800, 600);
scene.setFill(Color.LIGHTGREEN);
primaryStage.setTitle("Car");
primaryStage.setScene(scene);
Image car1Image = new Image(CIRCLES_128[0]);
Image car2Image = new Image(CIRCLES_128[1]);
ImageView car1 = new ImageView(car1Image);
ImageView car2 = new ImageView(car2Image);
car1.setFitHeight(100);//Resize image
car1.setFitWidth(100);
car1.relocate(100,100);
car2.setFitHeight(100);//Resize image
car2.setFitWidth(100);
car2.relocate(600,100);
//add to stage
canvas.getChildren().addAll(car1, car2);
final Timeline loop = new Timeline(new KeyFrame(Duration.millis(10), new EventHandler<ActionEvent>() {
double car1DeltaX = 3, car2DeltaX = 3; //each car must have its own deltaX and Y because
double car1DeltaY = 3, car2DeltaY = 3; //only one car has to change direction when hitting the edge
@Override
public void handle(final ActionEvent t) {
car1.setLayoutX(car1.getLayoutX() + car1DeltaX);
car1.setLayoutY(car1.getLayoutY() + car1DeltaY);
car2.setLayoutX(car2.getLayoutX() + car2DeltaX);
car2.setLayoutY(car2.getLayoutY() + car2DeltaY);
final Bounds bounds = canvas.getBoundsInLocal();
final Bounds car1Bounds = car1.getBoundsInParent();
final Bounds car2Bounds = car2.getBoundsInParent();
//check car1
final boolean car1AtRightBorder = car1Bounds.getMaxX() >= bounds.getMaxX() ;//- bounds.getRadius();
final boolean car1AtLeftBorder = car1Bounds.getMinX()<= bounds.getMinX() ;//+ car1.getRadius();
final boolean car1AtBottomBorder = car1Bounds.getMaxY() >= bounds.getMaxY() ;//- car1.getRadius();
final boolean car1AtTopBorder = car1Bounds.getMinY() <= bounds.getMinY() ;//+ car1.getRadius();
if (car1AtRightBorder || car1AtLeftBorder) {
car1DeltaX *= -1;
}
if (car1AtBottomBorder || car1AtTopBorder) {
car1DeltaY *= -1;
}
//check car2
final boolean car2AtRightBorder = car2Bounds.getMaxX() >= bounds.getMaxX() ;
final boolean car2AtLeftBorder = car2Bounds.getMinX()<= bounds.getMinX() ;
final boolean car2AtBottomBorder = car2Bounds.getMaxY() >= bounds.getMaxY() ;
final boolean car2AtTopBorder = car2Bounds.getMinY() <= bounds.getMinY() ;
if (car2AtRightBorder || car2AtLeftBorder) {
car2DeltaX *= -1;
}
if (car2AtBottomBorder || car2AtTopBorder) {
car2DeltaY *= -1;
}
}
}));
primaryStage.show();
loop.setCycleCount(Timeline.INDEFINITE);
loop.play();
}
static void main(String[] args) {
launch(args);
}
}
Затем вы можете добавить простой метод, чтобы определить, пересекаются ли две границы:
private boolean collisionDetected(Bounds b1, Bounds b2) {
return b1.intersects(b2);
}
и использовать его в l oop:
public void handle(final ActionEvent t) {
car1.setLayoutX(car1.getLayoutX() + car1DeltaX);
car1.setLayoutY(car1.getLayoutY() + car1DeltaY);
car2.setLayoutX(car2.getLayoutX() + car2DeltaX);
car2.setLayoutY(car2.getLayoutY() + car2DeltaY);
final Bounds bounds = canvas.getBoundsInLocal();
final Bounds car1Bounds = car1.getBoundsInParent();
final Bounds car2Bounds = car2.getBoundsInParent();
if(collisionDetected(car1Bounds, car2Bounds)){
car1DeltaX *= -1; car1DeltaY *= -1;
car2DeltaX *= -1; car2DeltaY *= -1;
}
//check car1
final boolean car1AtRightBorder = car1Bounds.getMaxX() >= bounds.getMaxX() ;
final boolean car1AtLeftBorder = car1Bounds.getMinX()<= bounds.getMinX() ;
final boolean car1AtBottomBorder = car1Bounds.getMaxY() >= bounds.getMaxY() ;
final boolean car1AtTopBorder = car1Bounds.getMinY() <= bounds.getMinY() ;
if (car1AtRightBorder || car1AtLeftBorder) {
car1DeltaX *= -1;
}
if (car1AtBottomBorder || car1AtTopBorder) {
car1DeltaY *= -1;
}
//check car2
final boolean car2AtRightBorder = car2Bounds.getMaxX() >= bounds.getMaxX() ;
final boolean car2AtLeftBorder = car2Bounds.getMinX()<= bounds.getMinX() ;
final boolean car2AtBottomBorder = car2Bounds.getMaxY() >= bounds.getMaxY() ;
final boolean car2AtTopBorder = car2Bounds.getMinY() <= bounds.getMinY() ;
if (car2AtRightBorder || car2AtLeftBorder) {
car2DeltaX *= -1;
}
if (car2AtBottomBorder || car2AtTopBorder) {
car2DeltaY *= -1;
}
}
}));
Ниже приведен вариант очистителя с рефакторингом:
public class Car extends Application {
private Pane canvas;
private static final String[] CIRCLES_128 = {
"https://cdn3.iconfinder.com/data/icons/softwaredemo/PNG/128x128/Circle_Green.png",
"https://cdn3.iconfinder.com/data/icons/softwaredemo/PNG/128x128/Circle_Red.png",
};
private double car1DeltaX = 3, car2DeltaX = 3; //each car must have its own deltaX and Y because
private double car1DeltaY = 3, car2DeltaY = 3; //only one car has to change direction when hitting the edge
@Override
public void start(final Stage primaryStage) throws FileNotFoundException {
canvas = new Pane();
final Scene scene = new Scene(canvas, 800, 600);
scene.setFill(Color.LIGHTGREEN);
primaryStage.setTitle("Car");
primaryStage.setScene(scene);
Image car1Image = new Image(CIRCLES_128[0]);
Image car2Image = new Image(CIRCLES_128[1]);
ImageView car1 = new ImageView(car1Image);
ImageView car2 = new ImageView(car2Image);
car1.setFitHeight(100);//Resize image
car1.setFitWidth(100);
car1.relocate(100,100);
car2.setFitHeight(100);//Resize image
car2.setFitWidth(100);
car2.relocate(600,100);
//add to stage
canvas.getChildren().addAll(car1, car2);
final Timeline loop = new Timeline(new KeyFrame(Duration.millis(10), t -> {
//move 2 cars to new position
positionNode(car1, car1DeltaX, car1DeltaY);
positionNode(car2, car2DeltaX, car2DeltaY);
final Bounds canvasBounds = canvas.getBoundsInLocal();
final Bounds car1Bounds = car1.getBoundsInParent();
final Bounds car2Bounds = car2.getBoundsInParent();
if(collisionDetected(car1Bounds, car2Bounds)){
handleCollision();
}
//check car1 within canvas bounds
if(atHorizontalEdge(canvasBounds,car1Bounds)){
car1DeltaX *= -1;
}
if(atVerticalEdge(canvasBounds,car1Bounds)){
car1DeltaY *= -1;
}
//check car2 within canvas bounds
if(atHorizontalEdge(canvasBounds,car2Bounds)){
car2DeltaX *= -1;
}
if(atVerticalEdge(canvasBounds,car2Bounds)){
car2DeltaY *= -1;
}
}));
primaryStage.show();
loop.setCycleCount(Timeline.INDEFINITE);
loop.play();
}
private void positionNode(Node node, double deltaX, double deltaY) {
node.setLayoutX(node.getLayoutX() + deltaX);
node.setLayoutY(node.getLayoutY() + deltaY);
}
private boolean collisionDetected(Bounds b1, Bounds b2) {
return b1.intersects(b2);
}
private boolean atHorizontalEdge(Bounds enclosing, Bounds enclosed) {
return enclosed.getMaxX() >= enclosing.getMaxX() || enclosed.getMinX()<= enclosing.getMinX() ;
}
private boolean atVerticalEdge(Bounds enclosing, Bounds enclosed) {
return enclosed.getMaxY() >= enclosing.getMaxY() || enclosed.getMinY()<= enclosing.getMinY() ;
}
private void handleCollision() {
//change cars directions
car1DeltaX *= -1; car1DeltaY *= -1;
car2DeltaX *= -1; car2DeltaY *= -1;
}
public static void main(String[] args) {
launch(args);
}
}