Проблемы с сообщениями ботов - PullRequest
0 голосов
/ 24 марта 2020

У меня есть команда, которая проверяет, существуют ли люди, а затем проверяет, входят ли они в группу, и затем продвигает их. Команда работает, и она продвигает их, но когда я набираю команду «Продвинуть кого-то», она отвечает следующим сообщением:

enter image description here

Она также не может найти ранг назовите и замените его на undefined.

Это мой код:

import * as Discord from "discord.js";
import { IBotCommand } from "../api";
import * as ConfigFile from "../config";
let express = require("express");
let roblox = require('noblox.js');

export default class Promote implements IBotCommand {

    private readonly _command = "promote";

    help(): string {
        return "Promote members in the Roblox group."
    }

    isThisCommand(command: string): boolean {
        return command === this._command;
    }


    async runCommand(args: string[], msgObject: Discord.Message, client: Discord.Client): Promise<void> {
        if (!msgObject.member.roles.find("name", "Council")) {
            msgObject.channel.send(`Nice try ${msgObject.author.username} but you don't have permission to promote members!`)
                .catch(console.error);
            return;

        }

        let groupId = 5293276;
        let maximumRank = ConfigFile.config.maximum_rank
        let username = args[0]
        if (username) {
            msgObject.channel.send(`Checking ROBLOX for ${username}`)
            roblox.getIdFromUsername(username)
                .then(function (id: any) {
                    roblox.getRankInGroup(groupId, id)
                        .then(function (rank: number) {
                            if (maximumRank <= rank) {
                                msgObject.channel.send(`${id} is rank ${rank} and not promotable.`)
                            } else {
                                msgObject.channel.send(`${id} is rank ${rank} and promotable.`)
                                roblox.promote(groupId, id)
                                    .then(function (roles: { oldRole: { Name: any; }; newRole: { Name: any; }; }) {
                                        msgObject.channel.send(`Promoted from ${roles.oldRole.Name} to ${roles.newRole.Name}`)
                                    }).catch(console.error)
                                        .then(msgObject.channel.send("Failed to promote."))

                            }
                        }).catch(console.error)
                            .then(
                                msgObject.channel.send("Couldn't get him in the group."));

                }).catch(console.error)
                .then(
                    msgObject.channel.send(`Sorry, but ${username} doesn't exist on ROBLOX.`));

        } else {
            msgObject.channel.send("Please enter a username.")
        }
        return;


    }
}

1 Ответ

0 голосов
/ 24 марта 2020

Метод find('name', 'name') был удален из discord.js использования find(role => role.name === 'value')

Но я рекомендую использовать role.id для выполнения проверок, потому что это безопаснее, и вы можете делать проверки следующим образом:

if (!msgObject.member.roles.has('roleID')) return  msgObject.channel.send(`Nice try ${msgObject.author.username} but you don't have permission to promote members!`)

Решение вашей проблемы:

import * as Discord from "discord.js";
import { IBotCommand } from "../api";
import * as ConfigFile from "../config";
let express = require("express");
let roblox = require('noblox.js');

export default class Promote implements IBotCommand {

    private readonly _command = "promote";

    help(): string {
        return "Promote members in the Roblox group."
    }

    isThisCommand(command: string): boolean {
        return command === this._command;
    }


    async runCommand(args: string[], msgObject: Discord.Message, client: Discord.Client): Promise<void> {
        if (!msgObject.member.roles.find(role => role.name === 'Council')) {
            msgObject.channel.send(`Nice try ${msgObject.author.username} but you don't have permission to promote members!`)
                .catch(console.error);
            return;

        }

        let groupId = 5293276;
        let maximumRank = ConfigFile.config.maximum_rank
        let username = args[0]
        if (username) {
            msgObject.channel.send(`Checking ROBLOX for ${username}`)
            roblox.getIdFromUsername(username)
                .then(function (id: any) {
                    roblox.getRankInGroup(groupId, id)
                        .then(function (rank: number) {
                            if (maximumRank <= rank) {
                                msgObject.channel.send(`${id} is rank ${rank} and not promotable.`)
                            } else {
                                msgObject.channel.send(`${id} is rank ${rank} and promotable.`)
                                roblox.promote(groupId, id)
                                    .then(function (roles: { oldRole: { Name: any; }; newRole: { Name: any; }; }) {
                                        msgObject.channel.send(`Promoted from ${roles.oldRole.Name} to ${roles.newRole.Name}`)
                                    }).catch(console.error)
                                        .then(msgObject.channel.send("Failed to promote."))

                            }
                        }).catch(console.error)
                            .then(
                                msgObject.channel.send("Couldn't get him in the group."));

                }).catch(console.error)
                .then(
                    msgObject.channel.send(`Sorry, but ${username} doesn't exist on ROBLOX.`));

        } else {
            msgObject.channel.send("Please enter a username.")
        }
        return;


    }
}
...